fix: always use the node displayname prop #2179
Conversation
It will fallback to basename anyways but will fix usage in public shares where the displayname is the real name but the basename is the share token. Also fixes end-to-end encryption ui. Signed-off-by: Ferdinand Thiessen <[email protected]>
|
/backport to stable6 |
Codecov Report❌ Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## main #2179 +/- ##
=======================================
Coverage 45.43% 45.43%
=======================================
Files 15 15
Lines 438 438
Branches 85 84 -1
=======================================
Hits 199 199
- Misses 210 211 +1
+ Partials 29 28 -1 ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
|
The backport to # Switch to the target branch and update it
git checkout stable6
git pull origin stable6
# Create the new backport branch
git checkout -b backport/2179/stable6
# Cherry pick the change from the commit sha1 of the change against the default branch
# This might cause conflicts, resolve them
git cherry-pick 5f99e206
# Push the cherry pick commit to the remote repository and open a pull request
git push origin backport/2179/stable6Error: Failed to check for changes with origin/stable6: No changes found in backport branch Learn more about backports at https://docs.nextcloud.com/server/stable/go.php?to=developer-backports. |
|
/backport to stable6 |
|
The backport to # Switch to the target branch and update it
git checkout stable6
git pull origin stable6
# Create the new backport branch
git checkout -b backport/2179/stable6
# Cherry pick the change from the commit sha1 of the change against the default branch
# This might cause conflicts, resolve them
git cherry-pick 5f99e206
# Push the cherry pick commit to the remote repository and open a pull request
git push origin backport/2179/stable6Error: Failed to check for changes with origin/stable6: No changes found in backport branch Learn more about backports at https://docs.nextcloud.com/server/stable/go.php?to=developer-backports. |
It will fallback to basename anyways but will fix usage in public shares where the displayname is the real name but the basename is the share token.
Also fixes end-to-end encryption ui.